PMD Results

The following document contains the results of PMD 5.1.2.

Files

org/mybatis/generator/ant/GeneratorAntTask.java

Violation Line
An empty statement (semicolon) not part of a loop 170

org/mybatis/generator/api/CommentGenerator.java

Violation Line
Avoid modifiers which are implied by the context 6062
Avoid modifiers which are implied by the context 64
Avoid modifiers which are implied by the context 6667
Avoid modifiers which are implied by the context 6970
Avoid modifiers which are implied by the context 7273
Avoid modifiers which are implied by the context 7577
Avoid modifiers which are implied by the context 7981
Avoid modifiers which are implied by the context 8384
Avoid modifiers which are implied by the context 98
Avoid modifiers which are implied by the context 107
Avoid modifiers which are implied by the context 121

org/mybatis/generator/api/FullyQualifiedTable.java

Violation Line
Too many static imports may lead to messy code 16336

org/mybatis/generator/api/IntrospectedTable.java

Violation Line
Avoid unused private methods such as 'isSubPackagesEnabled(PropertyHolder)'. 778

org/mybatis/generator/api/ShellRunner.java

Violation Line
An empty statement (semicolon) not part of a loop 141

org/mybatis/generator/api/dom/java/InitializationBlock.java

Violation Line
Useless parentheses. 106

org/mybatis/generator/api/dom/java/Method.java

Violation Line
Useless parentheses. 193

org/mybatis/generator/codegen/ibatis2/dao/elements/SelectByExampleWithoutBLOBsMethodGenerator.java

Violation Line
An empty statement (semicolon) not part of a loop 97

org/mybatis/generator/codegen/ibatis2/dao/elements/UpdateByExampleParmsInnerclassGenerator.java

Violation Line
An empty statement (semicolon) not part of a loop 83

org/mybatis/generator/codegen/ibatis2/model/ExampleGenerator.java

Violation Line
Avoid unused method parameters such as 'topLevelClass'. 240

org/mybatis/generator/codegen/ibatis2/sqlmap/elements/BaseColumnListElementGenerator.java

Violation Line
Useless parentheses. 64

org/mybatis/generator/codegen/ibatis2/sqlmap/elements/BlobColumnListElementGenerator.java

Violation Line
Useless parentheses. 65

org/mybatis/generator/codegen/ibatis2/sqlmap/elements/SelectByExampleWithoutBLOBsElementGenerator.java

Violation Line
Useless parentheses. 73

org/mybatis/generator/codegen/mybatis3/javamapper/SqlProviderGenerator.java

Violation Line
These nested if statements could be combined 8588

org/mybatis/generator/codegen/mybatis3/javamapper/elements/CountByExampleMethodGenerator.java

Violation Line
Avoid unnecessary return statements 65

org/mybatis/generator/codegen/mybatis3/javamapper/elements/DeleteByExampleMethodGenerator.java

Violation Line
Avoid unnecessary return statements 65

org/mybatis/generator/codegen/mybatis3/javamapper/elements/DeleteByPrimaryKeyMethodGenerator.java

Violation Line
Avoid unnecessary return statements 100

org/mybatis/generator/codegen/mybatis3/javamapper/elements/InsertMethodGenerator.java

Violation Line
Avoid unnecessary return statements 75

org/mybatis/generator/codegen/mybatis3/javamapper/elements/InsertSelectiveMethodGenerator.java

Violation Line
Avoid unnecessary return statements 67

org/mybatis/generator/codegen/mybatis3/javamapper/elements/SelectAllMethodGenerator.java

Violation Line
Avoid unnecessary return statements 70

org/mybatis/generator/codegen/mybatis3/javamapper/elements/SelectByExampleWithBLOBsMethodGenerator.java

Violation Line
Avoid unnecessary return statements 83

org/mybatis/generator/codegen/mybatis3/javamapper/elements/SelectByExampleWithoutBLOBsMethodGenerator.java

Violation Line
Avoid unnecessary return statements 86

org/mybatis/generator/codegen/mybatis3/javamapper/elements/SelectByPrimaryKeyMethodGenerator.java

Violation Line
Avoid unnecessary return statements 105

org/mybatis/generator/codegen/mybatis3/javamapper/elements/UpdateByExampleSelectiveMethodGenerator.java

Violation Line
Avoid unnecessary return statements 73

org/mybatis/generator/codegen/mybatis3/javamapper/elements/UpdateByExampleWithBLOBsMethodGenerator.java

Violation Line
Avoid unnecessary return statements 83

org/mybatis/generator/codegen/mybatis3/javamapper/elements/UpdateByExampleWithoutBLOBsMethodGenerator.java

Violation Line
Avoid unnecessary return statements 82

org/mybatis/generator/codegen/mybatis3/javamapper/elements/UpdateByPrimaryKeySelectiveMethodGenerator.java

Violation Line
Avoid unnecessary return statements 75

org/mybatis/generator/codegen/mybatis3/javamapper/elements/UpdateByPrimaryKeyWithBLOBsMethodGenerator.java

Violation Line
Avoid unnecessary return statements 76

org/mybatis/generator/codegen/mybatis3/javamapper/elements/UpdateByPrimaryKeyWithoutBLOBsMethodGenerator.java

Violation Line
Avoid unnecessary return statements 66

org/mybatis/generator/codegen/mybatis3/javamapper/elements/annotated/AnnotatedSelectByPrimaryKeyMethodGenerator.java

Violation Line
Too many static imports may lead to messy code 16188

org/mybatis/generator/codegen/mybatis3/model/ExampleGenerator.java

Violation Line
Avoid unused method parameters such as 'topLevelClass'. 210
Avoid unused method parameters such as 'topLevelClass'. 357

org/mybatis/generator/codegen/mybatis3/xmlmapper/MixedMapperGenerator.java

Violation Line
Avoid unnecessary return statements 29
Avoid unnecessary return statements 34
Avoid unnecessary return statements 39
Avoid unnecessary return statements 45
Avoid unnecessary return statements 51

org/mybatis/generator/codegen/mybatis3/xmlmapper/elements/BaseColumnListElementGenerator.java

Violation Line
Useless parentheses. 64

org/mybatis/generator/codegen/mybatis3/xmlmapper/elements/BlobColumnListElementGenerator.java

Violation Line
Useless parentheses. 65

org/mybatis/generator/codegen/mybatis3/xmlmapper/elements/InsertElementGenerator.java

Violation Line
These nested if statements could be combined 107110

org/mybatis/generator/codegen/mybatis3/xmlmapper/elements/SelectByExampleWithoutBLOBsElementGenerator.java

Violation Line
Useless parentheses. 70

org/mybatis/generator/codegen/mybatis3/xmlmapper/elements/SimpleSelectAllElementGenerator.java

Violation Line
Useless parentheses. 70

org/mybatis/generator/codegen/mybatis3/xmlmapper/elements/SimpleSelectByPrimaryKeyElementGenerator.java

Violation Line
Useless parentheses. 90

org/mybatis/generator/config/Context.java

Violation Line
These nested if statements could be combined 315317
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 316
These nested if statements could be combined 447449
An empty statement (semicolon) not part of a loop 538

org/mybatis/generator/config/GeneratedKey.java

Violation Line
These nested if statements could be combined 124127

org/mybatis/generator/config/TableConfiguration.java

Violation Line
Too many static imports may lead to messy code 16544
These nested if statements could be combined 503512

org/mybatis/generator/config/xml/IbatorConfigurationParser.java

Violation Line
Avoid unused method parameters such as 'configuration'. 93
Avoid unused private methods such as 'parseProperty(PropertyHolder,Node)'. 594

org/mybatis/generator/config/xml/MyBatisGeneratorConfigurationParser.java

Violation Line
Avoid unused method parameters such as 'configuration'. 90
Avoid unused private methods such as 'parseProperty(PropertyHolder,Node)'. 598

org/mybatis/generator/internal/DefaultCommentGenerator.java

Violation Line
Avoid unnecessary return statements 58
Avoid unnecessary return statements 94

org/mybatis/generator/internal/DomWriter.java

Violation Line
Useless parentheses. 150
Useless parentheses. 151
Avoid empty catch blocks 178181

org/mybatis/generator/internal/ObjectFactory.java

Violation Line
An empty statement (semicolon) not part of a loop 117
Avoid empty catch blocks 145147
Unnecessary use of fully qualified name 'StringUtility.stringHasValue' due to existing import 'org.mybatis.generator.internal.util.StringUtility' 252
Unnecessary use of fully qualified name 'StringUtility.stringHasValue' due to existing import 'org.mybatis.generator.internal.util.StringUtility' 265

org/mybatis/generator/internal/XmlFileMergerJaxp.java

Violation Line
These nested if statements could be combined 166168

org/mybatis/generator/internal/db/DatabaseIntrospector.java

Violation Line
Too many static imports may lead to messy code 16631
Avoid empty catch blocks 105107
An empty statement (semicolon) not part of a loop 118
Useless parentheses. 233
These nested if statements could be combined 313316
These nested if statements could be combined 336339

org/mybatis/generator/internal/rules/ConditionalModelRules.java

Violation Line
Useless parentheses. 58

org/mybatis/generator/internal/util/JavaBeansUtil.java

Violation Line
These nested if statements could be combined 6264
These nested if statements could be combined 9395

org/mybatis/generator/logging/Log.java

Violation Line
Avoid modifiers which are implied by the context 30
Avoid modifiers which are implied by the context 32